Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 12982: Disable the content sniffing algorithm if the server instructs us to do so wi... (Closed)

Created:
12 years ago by abarth-chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Disable the content sniffing algorithm if the server instructs us to do so with the nosniff directive. For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx R=deanm,darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6422

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/resource_dispatcher_host.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resource_dispatcher_host_uitest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/nosniff-test.html View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/nosniff-test.html.mock-http-headers View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
12 years ago (2008-12-05 07:01:38 UTC) #1
darin (slow to review)
LGTM Do you know of any work underway to standardize this (presumably without the X- ...
12 years ago (2008-12-05 07:10:46 UTC) #2
Dean McNamee
This is great! LGTM. http://codereview.chromium.org/12982/diff/1/3 File chrome/test/data/nosniff-test.html.mock-http-headers (right): http://codereview.chromium.org/12982/diff/1/3#newcode5 Line 5: Expires: Tue, 14 Nov ...
12 years ago (2008-12-05 07:11:31 UTC) #3
abarth-chromium
On 2008/12/05 07:10:46, darin wrote: > Do you know of any work underway to standardize ...
12 years ago (2008-12-05 07:16:28 UTC) #4
abarth-chromium
12 years ago (2008-12-05 07:16:39 UTC) #5
http://codereview.chromium.org/12982/diff/1/3
File chrome/test/data/nosniff-test.html.mock-http-headers (right):

http://codereview.chromium.org/12982/diff/1/3#newcode5
Line 5: Expires: Tue, 14 Nov 2006 19:23:58 GMT
On 2008/12/05 07:11:31, Dean McNamee wrote:
> Do we need the Date and Expires headers for any reason?

I don't think these matter, but I was being consistent with the other content
sniffing tests.  I can remove them all in a second patch, if you like.

Powered by Google App Engine
This is Rietveld 408576698