Add desktopui_IBusTest, that checks if IBus is working properly.

Add desktopui_IBusTest, that checks if IBus is working properly.

This is a preliminary version. We'll add more tests shortly.

IBus is an input method framework used in Chromium OS.
See http://www.chromium.org/chromium-os/chromiumos-design-docs/text-input
for details.

[petkov, 2010-03-25 16:13:18]

A few mostly style issues, LGTM otherwise.

Also, I'm not sure we need "Test" in the name of the test -- it's somewhat
redundant.

Feel free to check in once you fix the issues so that it gets counted for the
fix-it :-)

http://codereview.chromium.org/1297004/diff/1/6
File client/deps/ibusclient/src/Makefile (right):

http://codereview.chromium.org/1297004/diff/1/6#newcode2
client/deps/ibusclient/src/Makefile:2: -I/build/x86-generic/usr/include/dbus-1.0
\
Can you use "${SYSROOT}" instead of /build/x86-generic here? This whole thing is
executed under the autotest ebuild so you get the Portage board-specific
environment.

http://codereview.chromium.org/1297004/diff/1/9
File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right):

http://codereview.chromium.org/1297004/diff/1/9#newcode5
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:5: import logging
Per local CODING_STYLE, imports on one line.

http://codereview.chromium.org/1297004/diff/1/9#newcode12
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:12: version = 1
Per local CODING_STYLE, 4 space indent.

http://codereview.chromium.org/1297004/diff/1/9#newcode19
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:19: def
run_once(self):
Per local CODING_STYLE, two blank lines between methods.

http://codereview.chromium.org/1297004/diff/1/9#newcode30
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:30: cmd = 'su chronos
-c "DISPLAY=:0 %s"' % exefile
You should use site_ui.xcommand_as (or maybe even add xsystem_output_as :-) )

http://codereview.chromium.org/1297004/diff/1/9#newcode32
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:32:
logging.info(results)
This is what system_output's retain_output=True does -- no need to log twice.

[Yusuke Sato, 2010-03-26 00:24:12]

lgtm (supposing the issues petkov pointed out are addressed)

http://codereview.chromium.org/1297004/diff/1/7
File client/deps/ibusclient/src/ibusclient.cc (right):

http://codereview.chromium.org/1297004/diff/1/7#newcode6
client/deps/ibusclient/src/ibusclient.cc:6: #include <stdio.h>
nit: unnecessary #include?

[satorux1, 2010-03-26 02:08:30]

Thank you for the comments! Addressed all the comments. Will submit soon.

http://codereview.chromium.org/1297004/diff/1/6
File client/deps/ibusclient/src/Makefile (right):

http://codereview.chromium.org/1297004/diff/1/6#newcode2
client/deps/ibusclient/src/Makefile:2: -I/build/x86-generic/usr/include/dbus-1.0
\
On 2010/03/25 16:13:18, petkov wrote:
> Can you use "${SYSROOT}" instead of /build/x86-generic here? This whole thing
is
> executed under the autotest ebuild so you get the Portage board-specific
> environment.
> 

Good idea. Done.

http://codereview.chromium.org/1297004/diff/1/7
File client/deps/ibusclient/src/ibusclient.cc (right):

http://codereview.chromium.org/1297004/diff/1/7#newcode6
client/deps/ibusclient/src/ibusclient.cc:6: #include <stdio.h>
On 2010/03/26 00:24:12, Yusuke Sato wrote:
> nit: unnecessary #include?
> 

Done.

http://codereview.chromium.org/1297004/diff/1/9
File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right):

http://codereview.chromium.org/1297004/diff/1/9#newcode5
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:5: import logging
On 2010/03/25 16:13:18, petkov wrote:
> Per local CODING_STYLE, imports on one line.
> 

Done.

http://codereview.chromium.org/1297004/diff/1/9#newcode12
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:12: version = 1
On 2010/03/25 16:13:18, petkov wrote:
> Per local CODING_STYLE, 4 space indent.
> 

Done.

http://codereview.chromium.org/1297004/diff/1/9#newcode19
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:19: def
run_once(self):
On 2010/03/25 16:13:18, petkov wrote:
> Per local CODING_STYLE, two blank lines between methods.
> 

Done.

http://codereview.chromium.org/1297004/diff/1/9#newcode30
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:30: cmd = 'su chronos
-c "DISPLAY=:0 %s"' % exefile
On 2010/03/25 16:13:18, petkov wrote:
> You should use site_ui.xcommand_as (or maybe even add xsystem_output_as :-) )
> 

Done.

http://codereview.chromium.org/1297004/diff/1/9#newcode32
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:32:
logging.info(results)
On 2010/03/25 16:13:18, petkov wrote:
> This is what system_output's retain_output=True does -- no need to log twice.
> 

Done.