Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1297003: Make following ES5 function work with undetectable parameter/target (document... (Closed)

Created:
10 years, 9 months ago by pfeldman
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make following ES5 functions work with undetectable parameters/target (document.all): ObjectIsPrototypeOf ObjectDefineGetter ObjectLookupGetter ObjectDefineSetter ObjectLookupSetter ObjectKeys ObjectGetPrototypeOf ObjectGetOwnPropertyDescriptor ObjectGetOwnPropertyNames ObjectDefineProperty ObjectDefineProperties I did not implement tests covering calls with undetectable parameters since I would need to make these tests native. Just thought it was not worth the effort. If you think tests would make sense, I can add them. We might want to allow other functions to receive undetectable parameters, but I am not seeing any good candidates. Committed: http://code.google.com/p/v8/source/detail?r=4264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M src/v8natives.js View 11 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
10 years, 9 months ago (2010-03-25 11:21:54 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-25 12:09:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698