Issue 12945: Pull out revision 915 and 916 to get a green builder. I believe the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12945: Pull out revision 915 and 916 to get a green builder. I believe the... (Closed)

Created:
12 years ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
olehougaard

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Pull out revision 915 and 916 to get a green builder. I believe the issue has been resolved and these changes can go back in along with the fix tomorrow. TBR=olehougaard Committed: http://code.google.com/p/v8/source/detail?r=918

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -231 lines)			Patch
M	src/execution.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	src/top.h	View	4 chunks	+0 lines, -13 lines	0 comments	Download
M	src/top.cc	View	4 chunks	+24 lines, -61 lines	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+0 lines, -22 lines	0 comments	Download
D	test/message/try-catch-finally-return-in-finally.js	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	test/message/try-catch-finally-return-in-finally.out	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	test/message/try-finally-return-in-finally.js	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	test/message/try-finally-return-in-finally.out	View	1 chunk	+0 lines, -28 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

olehougaard

12 years ago (2008-12-05 07:43:43 UTC) #2

On 2008/12/04 14:34:34, Mads Ager wrote:
> 

Yeah, okay. LGTM, I guess.

Expand Messages | Collapse Messages