Issue 12928: Implement visited link coloring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12928: Implement visited link coloring. (Closed)

Created:
12 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
macdome, eseidel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement visited link coloring. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6970

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -24 lines)			Patch
M	chrome/common/visitedlink_common.h	View	1	2 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/common/visitedlink_common.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_glue.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webkit/build/WebCore/WebCore.vcproj	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/build/port/port.vcproj	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/chromium_bridge_impl.cc	View	1	3 chunks	+36 lines, -8 lines	1 comment	Download
M	webkit/glue/webkit_glue.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/port/platform/chromium/ChromiumBridge.h	View		2 chunks	+7 lines, -4 lines	0 comments	Download
A	webkit/port/platform/chromium/LinkHashChromium.cpp	View		1 chunk	+47 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

macdome_gmail.com

12 years ago (2008-12-13 01:36:27 UTC) #2

Looks fine.

http://codereview.chromium.org/12928/diff/201/402
File webkit/glue/chromium_bridge_impl.cc (right):

http://codereview.chromium.org/12928/diff/201/402#newcode529
Line 529: url_canon::RawCanonOutput<2048> buffer;
Pixels?  Edict?  Sound?  Yes, we speak a crazy language.

Expand Messages | Collapse Messages