Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1292003: autox: Add support for creating and querying windows. (Closed)

Created:
10 years, 9 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone, sosa
CC:
chromium-os-reviews_chromium.org, Daniel Erat
Visibility:
Public.

Description

autox: Add support for creating and querying windows. The asynchronous stuff makes this a bit tricky -- we wait for a window to be mapped and exposed before returning from create_and_map_window() (in case the caller wants to, say, take a screenshot), and provide an await_condition() method that will hopefully mask delays between when a test makes a request and when the change is actually applied by the window manager. BUG=none TEST=tried it with a little test script; it works

Patch Set 1 #

Total comments: 2

Patch Set 2 : improve how we track window state #

Patch Set 3 : apply feedback #

Patch Set 4 : fix typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -1 line) Patch
M src/platform/autox/autox.py View 1 2 3 6 chunks +211 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
10 years, 9 months ago (2010-03-25 01:23:48 UTC) #1
sosa
Sorry the review took some time but I had to look up some x func's. ...
10 years, 9 months ago (2010-03-25 16:27:46 UTC) #2
Daniel Erat
Thanks. I made a few more changes while you were reviewing, if you don't mind ...
10 years, 9 months ago (2010-03-25 16:41:26 UTC) #3
sosa
10 years, 9 months ago (2010-03-25 16:43:46 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698