Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 12913: Get the test plugin compiling and working for the Mac. (Closed)

Created:
12 years ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Get the test plugin compiling and working for the Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6308

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -0 lines) Patch
A build/dynamiclib.xcconfig View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/npapi/bindings/npapi.h View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/tools/npapi_layout_test_plugin/Info.plist View 1 chunk +48 lines, -0 lines 0 comments Download
A webkit/tools/npapi_layout_test_plugin/Info.r View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A webkit/tools/npapi_layout_test_plugin/npapi_layout_test_plugin.xcodeproj/project.pbxproj View 1 2 1 chunk +262 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
12 years ago (2008-12-03 19:15:32 UTC) #1
Mark Mentovai
Looks OK, I looked for a few things in the project file and everything seems ...
12 years ago (2008-12-03 19:30:34 UTC) #2
Amanda Walker
lgtm.
12 years ago (2008-12-03 19:41:03 UTC) #3
Avi (use Gerrit)
mark-if you like http://codereview.chromium.org/12913/diff/7/210 File build/sharedlib.xcconfig (right): http://codereview.chromium.org/12913/diff/7/210#newcode1 Line 1: // Copyright (c) 2008 The ...
12 years ago (2008-12-03 19:59:28 UTC) #4
Mark Mentovai
12 years ago (2008-12-03 20:27:15 UTC) #5
l
  g
 t
m

Powered by Google App Engine
This is Rietveld 408576698