Issue 12911: Move skia_utils_mac from base/gfx to skia/ext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12911: Move skia_utils_mac from base/gfx to skia/ext. (Closed)

Created:
12 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move skia_utils_mac from base/gfx to skia/ext. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6302

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -147 lines)			Patch
M	base/base.xcodeproj/project.pbxproj	View	4 chunks	+0 lines, -6 lines	0 comments	Download
D	base/gfx/skia_utils_mac.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	base/gfx/skia_utils_mac.cc	View	1 chunk	+0 lines, -83 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/platform_device_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	skia/ext/skia_utils_mac.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
A +	skia/ext/skia_utils_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/skia.xcodeproj/project.pbxproj	View	4 chunks	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

12 years ago (2008-12-03 19:38:01 UTC) #2

LGTM with alphabetizing.

http://codereview.chromium.org/12911/diff/1/2
File skia/skia.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/12911/diff/1/2#newcode1055
Line 1055: A708CBA30EE7078500C531EA /* skia_utils_mac.cc in Sources */,
please alphabetize this in the target sources list (and the above two files
while you're at it).

Expand Messages | Collapse Messages