Reporting uncaught errors at the boundary between C++ and JS instead of tryin...

test/cctest/test-api.cc

 // Copyright 2007-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2942 matching lines @@
 static int report_count = 0;
 static void ApiUncaughtExceptionTestListener(v8::Handle<v8::Message>,
                                              v8::Handle<Value>) {
   report_count++;
 }
 
 
 // Counts uncaught exceptions, but other tests running in parallel
 // also have uncaught exceptions.
 TEST(ApiUncaughtException) {
+  report_count = 0;
   v8::HandleScope scope;
   LocalContext env;
   v8::V8::AddMessageListener(ApiUncaughtExceptionTestListener);
 
   Local<v8::FunctionTemplate> fun = v8::FunctionTemplate::New(TroubleCallback);
   v8::Local<v8::Object> global = env->Global();
   global->Set(v8_str("trouble"), fun->GetFunction());
 
   Script::Compile(v8_str("function trouble_callee() {"
                          "  var x = null;"
                          "  return x.foo;"
                          "};"
                          "function trouble_caller() {"
                          "  trouble();"
                          "};"))->Run();
   Local<Value> trouble = global->Get(v8_str("trouble"));
   CHECK(trouble->IsFunction());
   Local<Value> trouble_callee = global->Get(v8_str("trouble_callee"));
   CHECK(trouble_callee->IsFunction());
   Local<Value> trouble_caller = global->Get(v8_str("trouble_caller"));
   CHECK(trouble_caller->IsFunction());
   Function::Cast(*trouble_caller)->Call(global, 0, NULL);
   CHECK_EQ(1, report_count);
+  v8::V8::RemoveMessageListeners(ApiUncaughtExceptionTestListener);
+}
+
+
+TEST(TryCatchFinallyUsingMessaging) {

[Søren Thygesen Gjesse, 2008/12/04 07:53:53]

I suggest to change this test into one or more message test written in
JavaScript. We already have most of the try-catch-finally covered by a set of
message tests, with exception cancellation by returning from finally missing.

[olehougaard, 2008/12/04 08:44:35]

Fixed.

+  report_count = 0;
+  v8::HandleScope scope;
+  LocalContext env;
+  v8::V8::AddMessageListener(ApiUncaughtExceptionTestListener);
+  Script::Compile(v8_str("try { throw ''; } catch (e) {}"))->Run();
+  CHECK_EQ(0, report_count);
+  Script::Compile(v8_str("try { throw ''; } finally {}"))->Run();
+  CHECK_EQ(1, report_count);
+  Script::Compile(v8_str("(function() { try { throw ''; } finally { return; } })()"))->Run();

[Mads Ager (chromium), 2008/12/03 15:44:48]

These two lines seem too long?  Break them by using the C++ concatenation of
adjacent strings?

[olehougaard, 2008/12/04 08:44:35]

Fixed

+  CHECK_EQ(1, report_count);
+  Script::Compile(v8_str("(function() { try { throw ''; } finally { throw 0; } })()"))->Run();
+  CHECK_EQ(2, report_count);
+  v8::V8::RemoveMessageListeners(ApiUncaughtExceptionTestListener);
+}
+
+
+TEST(TryCatchFinallyUsingTryCatchHandler) {
+  v8::HandleScope scope;
+  LocalContext env;
+  v8::TryCatch try_catch;
+  Script::Compile(v8_str("try { throw ''; } catch (e) {}"))->Run();
+  CHECK(!try_catch.HasCaught());
+  Script::Compile(v8_str("try { throw ''; } finally {}"))->Run();
+  CHECK(try_catch.HasCaught());
+  try_catch.Reset();
+  Script::Compile(v8_str("(function() { try { throw ''; } finally { return; } })()"))->Run();
+  CHECK(!try_catch.HasCaught());
+  Script::Compile(v8_str("(function() { try { throw ''; } finally { throw 0; } })()"))->Run();
+  CHECK(try_catch.HasCaught());
 }
 
 
 // SecurityHandler can't be run twice
 TEST(SecurityHandler) {
   v8::HandleScope scope0;
   v8::Handle<v8::ObjectTemplate> global_template = v8::ObjectTemplate::New();
   global_template->SetAccessCheckCallbacks(NamedSecurityTestCallback,
                                            IndexedSecurityTestCallback);
   // Create an environment
@@ skipping 2356 matching lines @@
     CompileRun("for (var j = 0; j < 10; j++) new RegExp('');");
   }
   // Test CallIC.
   for (int i = 0; i < 2; i++) {
     LocalContext context;
     context->Global()->Set(v8_str("tmp"), v8::True());
     context->Global()->Delete(v8_str("tmp"));
     CompileRun("for (var j = 0; j < 10; j++) RegExp('')");
   }
 }