Reporting uncaught errors at the boundary between C++ and JS instead of tryin...

src/execution.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 77 matching lines @@
   }
 
 #ifdef DEBUG
   value->Verify();
 #endif
 
   // Update the pending exception flag and return the value.
   *has_pending_exception = value->IsException();
   ASSERT(*has_pending_exception == Top::has_pending_exception());
   if (*has_pending_exception) {
+    Top::ReportPendingMessages();
+    return Handle<Object>();
+  } else {
+    Top::clear_pending_message();

[Søren Thygesen Gjesse, 2008/12/04 07:53:53]

If there is no pending exception clearing it should not be needed.

[olehougaard, 2008/12/04 08:44:35]

Removed.

     Top::setup_external_caught();

[Mads Ager (chromium), 2008/12/03 15:44:48]

Why is setup_external_caught needed in the case that there was no exception?

[olehougaard, 2008/12/04 08:44:35]

It isn't. Removed.

-    // If the pending exception is OutOfMemoryException set out_of_memory in
-    // the global context.  Note: We have to mark the global context here
-    // since the GenerateThrowOutOfMemory stub cannot make a RuntimeCall to
-    // set it.
-    if (Top::pending_exception() == Failure::OutOfMemoryException()) {
-      Top::context()->mark_out_of_memory();
-    }
-    return Handle<Object>();
   }
 
   return Handle<Object>(value);
 }
 
 
 Handle<Object> Execution::Call(Handle<JSFunction> func,
                                Handle<Object> receiver,
                                int argc,
                                Object*** args,
@@ skipping 403 matching lines @@
   // All allocation spaces other than NEW_SPACE have the same effect.
   Heap::CollectGarbage(0, OLD_DATA_SPACE);
   return v8::Undefined();
 }
 
 
 static GCExtension kGCExtension;
 v8::DeclareExtension kGCExtensionDeclaration(&kGCExtension);
 
 } }  // namespace v8::internal