Reporting uncaught errors at the boundary between C++ and JS instead of tryin...

src/builtins.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 336 matching lines @@
     return Top::Throw(*obj);
   }
 
   Object* raw_call_data = fun_data->call_code();
   if (!raw_call_data->IsUndefined()) {
     CallHandlerInfo* call_data = CallHandlerInfo::cast(raw_call_data);
     Object* callback_obj = call_data->callback();
     v8::InvocationCallback callback =
         v8::ToCData<v8::InvocationCallback>(callback_obj);
     Object* data_obj = call_data->data();
-    Object* result;
 
     v8::Local<v8::Object> self =
         v8::Utils::ToLocal(Handle<JSObject>::cast(receiver));
     Handle<Object> data_handle(data_obj);
     v8::Local<v8::Value> data = v8::Utils::ToLocal(data_handle);
     ASSERT(raw_holder->IsJSObject());
     v8::Local<v8::Function> callee = v8::Utils::ToLocal(function);
     Handle<JSObject> holder_handle(JSObject::cast(raw_holder));
     v8::Local<v8::Object> holder = v8::Utils::ToLocal(holder_handle);
     LOG(ApiObjectAccess("call", JSObject::cast(*receiver)));
     v8::Arguments args = v8::ImplementationUtilities::NewArguments(
         data,
         holder,
         callee,
         is_construct,
         reinterpret_cast<void**>(__argv__ - 1),
         __argc__ - 1);
 
     v8::Handle<v8::Value> value;
     {
       // Leaving JavaScript.
       VMState state(OTHER);
       value = callback(args);
     }
+    Object* result;
     if (value.IsEmpty()) {
       result = Heap::undefined_value();
     } else {
       result = *reinterpret_cast<Object**>(*value);
     }
+    if (result->IsException()) {
+      ASSERT(Top::has_pending_exception());
+      Top::ReportPendingMessages();

[Mads Ager (chromium), 2008/12/03 15:44:48]

I'm not sure I understand why we need to check here?  There are a lot of places
in the code where we invoke a c++ callback function.  If we need to check here,
don't we need to check in the other places as well?

[olehougaard, 2008/12/04 08:44:35]

This was a remnant from an earlier effort to get the tests working. Removed.

+    }
 
     RETURN_IF_SCHEDULED_EXCEPTION();
     if (!is_construct || result->IsJSObject()) return result;
   }
 
   return *receiver;
 }
 BUILTIN_END
 
 
@@ skipping 297 matching lines @@
       if (entry->contains(pc)) {
         return names_[i];
       }
     }
   }
   return NULL;
 }
 
 
 } }  // namespace v8::internal