Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1289003: Removed custom FFmpegLock. Removed ffmpeg headers from third_party/ffmpeg/include. (Closed)

Created:
10 years, 9 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, Paweł Hajdan Jr., fbarchard, awong, Alpha Left Google
Visibility:
Public.

Description

Removed custom FFmpegLock. Removed ffmpeg headers from third_party/ffmpeg/include. Patch by sergeyu@chromium.org BUG=23271 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -7312 lines) Patch
M DEPS View 3 chunks +4 lines, -6 lines 0 comments Download
M media/base/mock_ffmpeg.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/mock_ffmpeg.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.h View 1 chunk +3 lines, -23 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M media/filters/ffmpeg_glue.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decode_engine.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M media/filters/ffmpeg_video_decode_engine_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/ffmpeg/avcodec-52.sigs View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/ffmpeg/ffmpeg.gyp View 4 chunks +6 lines, -4 lines 0 comments Download
M third_party/ffmpeg/ffmpeg_stub_headers.fragment View 1 chunk +4 lines, -2 lines 0 comments Download
D third_party/ffmpeg/include/libavcodec/avcodec.h View 1 chunk +0 lines, -3755 lines 0 comments Download
D third_party/ffmpeg/include/libavcodec/opt.h View 1 chunk +0 lines, -156 lines 0 comments Download
D third_party/ffmpeg/include/libavcodec/vdpau.h View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/ffmpeg/include/libavcodec/xvmc.h View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/ffmpeg/include/libavformat/avformat.h View 1 chunk +0 lines, -1238 lines 0 comments Download
D third_party/ffmpeg/include/libavformat/avio.h View 1 chunk +0 lines, -406 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/adler32.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/avstring.h View 1 chunk +0 lines, -90 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/avutil.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/base64.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/common.h View 1 chunk +0 lines, -286 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/crc.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/fifo.h View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/intfloat_readwrite.h View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/log.h View 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/lzo.h View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/mathematics.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/md5.h View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/mem.h View 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/pixfmt.h View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/rational.h View 1 chunk +0 lines, -129 lines 0 comments Download
D third_party/ffmpeg/include/libavutil/sha1.h View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
This change 1) doesn't describe what it's for 2) has no review comments What's going ...
10 years, 9 months ago (2010-03-29 18:12:10 UTC) #1
Evan Martin
(That is, saying "delete files and change some others" is emphatically *not* a useful commit ...
10 years, 9 months ago (2010-03-29 18:12:34 UTC) #2
Evan Martin
On 2010/03/29 18:12:34, Evan Martin wrote: > (That is, saying "delete files and change some ...
10 years, 9 months ago (2010-03-29 18:16:56 UTC) #3
scherkus (not reviewing)
On 2010/03/29 18:16:56, Evan Martin wrote: > On 2010/03/29 18:12:34, Evan Martin wrote: > > ...
10 years, 9 months ago (2010-03-29 18:24:32 UTC) #4
Evan Martin
10 years, 9 months ago (2010-03-29 18:26:32 UTC) #5
On 2010/03/29 18:24:32, scherkus wrote:
> Forgot original review link:
> http://codereview.chromium.org/859001

That one doesn't say what's going on either, though...

it seems third_party/README.chromium has a description of an include/ dir.  is
that obsolete now?

Powered by Google App Engine
This is Rietveld 408576698