Implement GetCPUUsage; it was causing link errors because of its absence on t...

Implement GetCPUUsage; it was causing link errors because of its absence on the Mac, so we'll implement it for everyone.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6221

[Avi (use Gerrit), 2008-12-02 16:01:06]

Dan--

This should fix things.

[pink (ping after 24hrs), 2008-12-02 19:36:11]

http://codereview.chromium.org/12869/diff/1/2
File base/process_util_posix.cc (right):

http://codereview.chromium.org/12869/diff/1/2#newcode63
Line 63: int retval;
declare retval where it's initialized or give it an initial value.

http://codereview.chromium.org/12869/diff/1/2#newcode76
Line 76: processor_count_;
does |processor_count_| get scaled to an int64 or do the other values get scaled
down to 32bits? just making sure.

http://codereview.chromium.org/12869/diff/1/2#newcode79
Line 79: if ((last_system_time_ == 0) || (last_time_ == 0)) {
don't need the extra parens, but not a biggie.

[Avi (use Gerrit), 2008-12-02 19:40:31]

http://codereview.chromium.org/12869/diff/1/2
File base/process_util_posix.cc (right):

http://codereview.chromium.org/12869/diff/1/2#newcode76
Line 76: processor_count_;
On 2008/12/02 19:36:11, pink wrote:
> does |processor_count_| get scaled to an int64 or do the other values get
scaled
> down to 32bits? just making sure.

I'm pretty sure int64/int32 causes the int32 to be promoted.

http://codereview.chromium.org/12869/diff/1/2#newcode79
Line 79: if ((last_system_time_ == 0) || (last_time_ == 0)) {
On 2008/12/02 19:36:11, pink wrote:
> don't need the extra parens, but not a biggie.

Straight from the Windows code.