Issue 12833: Making sure that the buffer we use with ReadFile/WriteFile is page...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12833: Making sure that the buffer we use with ReadFile/WriteFile is page... (Closed)

Created:
12 years ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Making sure that the buffer we use with ReadFile/WriteFile is page aligned. Also restoring file attributes after evicting it from the cache (since the function writes to the file). Depending on hardware, file operations will fail if the buffer isn't aligned when using the FILE_FLAG_NO_BUFFERING flag. For more details: http://msdn.microsoft.com/en-us/library/cc644950(VS.85).aspx Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6157

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -10 lines)			Patch
	M	base/test_file_util_win.cc	View		1 chunk	+67 lines, -10 lines	0 comments	Download

Total messages: 1 (0 generated)

tommi (sloooow) - chröme

12 years ago (2008-12-01 19:53:13 UTC) #1

hey brett - this is the same change as before, but after fixing my gclient spec