Change Windows daylight saving time calculations to...

Change Windows daylight saving time calculations to
use C stdlib local time functions, not Win32 functions.
Win32 time functions slowed down with Windows XP SP3.
Change all platforms to use equivalent years between 2008 and
2035 for years outside the range 1970..2037.

Committed: http://code.google.com/p/v8/source/detail?r=896

[William Hesse, 2008-12-01 13:50:02]

Here is the change in the daylight saving time lookup
code.  I also have a browser test for it, which I will email you.  I would like
someone in the US to test it on a US Windows system, to check US DST
calculations.

It is much faster on Windows XP SP 3.

[Mads Ager (chromium), 2008-12-01 14:17:18]

LGTM.

Too bad that the more correct system call became that slow in SP3.  :-(

http://codereview.chromium.org/12824/diff/201/202
File src/platform-win32.cc (right):

http://codereview.chromium.org/12824/diff/201/202#newcode453
Line 453: if (posix_time >= 32535244800i64) return 0;  // Jan 1, 3001.
_MAX__TIME64_T
Please start this comment on a new line.

[Mike Belshe, 2008-12-01 17:23:52]

lgtm

I assume you ran this through the mozilla tests?  I know we had trouble finding
the right sequence of win32 apis when we did this the first time.  

I think the bug the ensure against is that computing the offset for a time which
was in DST when we're no longer in DST still works.

For instance, set your machine to be US time, in DST.  Then run the tests. 
Then, set your machine to be without DST and run the tests again.

http://codereview.chromium.org/12824/diff/201/202
File src/platform-win32.cc (right):

http://codereview.chromium.org/12824/diff/201/202#newcode453
Line 453: if (posix_time >= 32535244800i64) return 0;  // Jan 1, 3001.
_MAX__TIME64_T
nit: I find this code unnecessarily compressed; do you mind moving the return
statements to a newline?

[William Hesse, 2008-12-02 13:18:10]

Recommended changes made.  Other changes also made for correctness. Submitting. 
Please review again.

[Mads Ager (chromium), 2008-12-02 13:38:55]

LGTM.