Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 128001: Revert "Make TCPClientSocketPool own the ConnectingSockets." (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_unittest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 18ff111a1777a17bd06ca7074e37dfbb1a9a0d43..3af95e27321ada3c2357fe758259950e39f96a58 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -45,7 +45,10 @@ namespace {
class URLRequestHttpCacheContext : public URLRequestContext {
public:
URLRequestHttpCacheContext() {
- host_resolver_ = new net::HostResolver;
+ // TODO(eroman): we turn off host caching to see if synchronous
+ // host resolving interacts poorly with client socket pool. [experiment]
+ // http://crbug.com/13952
+ host_resolver_ = new net::HostResolver(0, 0);
proxy_service_ = net::ProxyService::CreateNull();
http_transaction_factory_ =
new net::HttpCache(
@@ -315,7 +318,8 @@ TEST_F(HTTPSRequestTest, MAYBE_HTTPSExpiredTest) {
}
}
-TEST_F(URLRequestTest, CancelTest) {
+// http://crbug.com/13952
+TEST_F(URLRequestTest, DISABLED_CancelTest) {
TestDelegate d;
{
TestURLRequest r(GURL("http://www.google.com/"), &d);
@@ -338,7 +342,8 @@ TEST_F(URLRequestTest, CancelTest) {
#endif
}
-TEST_F(URLRequestTest, CancelTest2) {
+// http://crbug.com/13952
+TEST_F(URLRequestTest, DISABLED_CancelTest2) {
scoped_refptr<HTTPTestServer> server =
HTTPTestServer::CreateServer(L"", NULL);
ASSERT_TRUE(NULL != server.get());
@@ -367,7 +372,8 @@ TEST_F(URLRequestTest, CancelTest2) {
#endif
}
-TEST_F(URLRequestTest, CancelTest3) {
+// http://crbug.com/13952
+TEST_F(URLRequestTest, DISABLED_CancelTest3) {
scoped_refptr<HTTPTestServer> server =
HTTPTestServer::CreateServer(L"", NULL);
ASSERT_TRUE(NULL != server.get());
@@ -395,7 +401,8 @@ TEST_F(URLRequestTest, CancelTest3) {
#endif
}
-TEST_F(URLRequestTest, CancelTest4) {
+// http://crbug.com/13952
+TEST_F(URLRequestTest, DISABLED_CancelTest4) {
scoped_refptr<HTTPTestServer> server =
HTTPTestServer::CreateServer(L"", NULL);
ASSERT_TRUE(NULL != server.get());
« no previous file with comments | « net/url_request/url_request_unittest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698