Rework ordering in ExtensionsService::UninstallExtension()

Rework ordering in ExtensionsService::UninstallExtension()

BUG=39147
TEST=Existing tests in extensions_service_unittest.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42752

[use mnissler at chromium.org, 2010-03-25 17:16:58]

Erik, here is my proposal. Note that I've removed the
UnregisterChromeURLOverrides() call, since it is already called from
UnloadExtension().

[Erik does not do reviews, 2010-03-25 19:29:31]

LGTM

http://codereview.chromium.org/1278003/diff/2001/3003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/1278003/diff/2001/3003#newcode278
chrome/browser/extensions/extensions_service.cc:278: // Also copy the extension
identifier since the reference might have been
nit: newline above comment

http://codereview.chromium.org/1278003/diff/2001/3003#newcode282
chrome/browser/extensions/extensions_service.cc:282:
UnloadExtension(extension_id);
maybe add a comment here: "Unload before doing more cleanup to ensure that
nothing is hanging on to any of these resources."

[use mnissler at chromium.org, 2010-03-26 10:14:43]

http://codereview.chromium.org/1278003/diff/2001/3003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/1278003/diff/2001/3003#newcode278
chrome/browser/extensions/extensions_service.cc:278: // Also copy the extension
identifier since the reference might have been
On 2010/03/25 19:29:31, Erik Kay wrote:
> nit: newline above comment

Done.

http://codereview.chromium.org/1278003/diff/2001/3003#newcode282
chrome/browser/extensions/extensions_service.cc:282:
UnloadExtension(extension_id);
On 2010/03/25 19:29:31, Erik Kay wrote:
> maybe add a comment here: "Unload before doing more cleanup to ensure that
> nothing is hanging on to any of these resources."

Done.