Issue 1276003: Append a number to make app shortcut name unique.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276003: Append a number to make app shortcut name unique. (Closed)

Created:
10 years, 9 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paul Godavari, ben+cc_chromium.org

Visibility:
Public.

Description

Append a number to make app shortcut name unique. - Move DownloadManager's unique path helpers into download utils; - Use those functions to make shortcut file name unqiue. BUG=642 TEST=Verify fixes for issue 642. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42769

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -38 lines)			Patch
M	chrome/browser/download/download_manager.cc	View	5 chunks	+9 lines, -34 lines	0 comments	Download
M	chrome/browser/download/download_util.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/web_applications/web_app.cc	View	3 chunks	+23 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages