Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: trychange.py

Issue 1272003: e.stderr may be None (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 85d589f0f1d8e64d4b4b4e87e7a5dcc3a281d6dd..0f70130c32885cf938ed744ebd27dc27f07702f8 100755
--- a/trychange.py
+++ b/trychange.py
@@ -372,8 +372,10 @@ def _SendChangeSVN(options):
gclient_utils.CheckCall(["svn", "commit", full_path, '--file',
temp_file.name], print_error=False)
except gclient_utils.CheckCallError, e:
- raise NoTryServerAccess(' '.join(e.command) + '\nOuput:\n' +
- e.stdout + e.stderr)
+ out = e.stdout
+ if e.stderr:
+ out += e.stderr
+ raise NoTryServerAccess(' '.join(e.command) + '\nOuput:\n' + out)
finally:
temp_file.close()
shutil.rmtree(temp_dir, True)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698