Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 12701: Checking in media common header file and buffer pure interfaces. (Closed)

Created:
12 years ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Checking in media buffer pure interfaces. R=cpu,darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6167

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 18

Patch Set 4 : Updated media/base/buffers.h based on Darin's comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -20 lines) Patch
M media/base/buffers.h View 1 2 3 5 chunks +37 lines, -20 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
scherkus (not reviewing)
12 years ago (2008-11-26 23:25:12 UTC) #1
cpu_(ooo_6.6-7.5)
Hi can you add darin to the reviewers? thanks
12 years ago (2008-11-27 01:57:03 UTC) #2
cpu_(ooo_6.6-7.5)
Some basic style nits. BTW, where is this set of files located with respect to ...
12 years ago (2008-11-27 02:13:14 UTC) #3
scherkus (not reviewing)
Fixed up header includes, data types and comments. http://codereview.chromium.org/12701/diff/1/3 File media/base/buffers.h (right): http://codereview.chromium.org/12701/diff/1/3#newcode7 Line 7: ...
12 years ago (2008-12-01 20:08:58 UTC) #4
cpu_(ooo_6.6-7.5)
LGTM On 2008/12/01 20:08:58, scherkus wrote: > Fixed up header includes, data types and comments. ...
12 years ago (2008-12-01 21:28:44 UTC) #5
darin (slow to review)
http://codereview.chromium.org/12701/diff/403/405 File media/base/buffers.h (right): http://codereview.chromium.org/12701/diff/403/405#newcode4 Line 4: nit: please add a block comment here describing ...
12 years ago (2008-12-08 18:05:18 UTC) #6
scherkus (not reviewing)
Updated based on Darin's comments. http://codereview.chromium.org/12701/diff/403/405 File media/base/buffers.h (right): http://codereview.chromium.org/12701/diff/403/405#newcode4 Line 4: On 2008/12/08 18:05:18, ...
12 years ago (2008-12-08 19:46:59 UTC) #7
darin (slow to review)
12 years ago (2008-12-08 20:40:47 UTC) #8
LGTM, thanks!

http://codereview.chromium.org/12701/diff/209/210
File media/base/buffers.h (right):

http://codereview.chromium.org/12701/diff/209/210#newcode5
Line 5: // Defines various types of timestamped media buffers used for
transporting
nice!

Powered by Google App Engine
This is Rietveld 408576698