Issue 12656: Linux: match average char width with Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12656: Linux: match average char width with Windows (Closed)

Created:
12 years ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, ojan

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: match average char width with Windows

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -7 lines)			Patch
M	skia/include/SkPaint.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/ports/SkFontHost_FreeType.cpp	View	4 chunks	+10 lines, -3 lines	0 comments	Download
M	webkit/port/platform/graphics/chromium/FontCacheLinux.cpp	View	2 chunks	+1 line, -2 lines	1 comment	Download
M	webkit/port/platform/graphics/chromium/SimpleFontDataLinux.cpp	View	1 chunk	+7 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

agl

http://codereview.chromium.org/12656/diff/1/4 File webkit/port/platform/graphics/chromium/FontCacheLinux.cpp (left): http://codereview.chromium.org/12656/diff/1/4#oldcode45 Line 45: notImplemented(); I removed this because it matches the ...

12 years ago (2008-11-25 23:24:02 UTC) #2

ojan

drive-by... http://codereview.chromium.org/12656/diff/1/5 File webkit/port/platform/graphics/chromium/SimpleFontDataLinux.cpp (right): http://codereview.chromium.org/12656/diff/1/5#newcode61 Line 61: static const UChar32 x_char = 'x'; Why ...

12 years ago (2008-11-26 00:17:45 UTC) #3

agl

12 years ago (2008-11-26 00:22:19 UTC) #5

http://codereview.chromium.org/12656/diff/1/5
File webkit/port/platform/graphics/chromium/SimpleFontDataLinux.cpp (right):

http://codereview.chromium.org/12656/diff/1/5#newcode61
Line 61: static const UChar32 x_char = 'x';
On 2008/11/26 00:17:45, ojan wrote:
> Why "x" as the fallback? This is what Firefox uses, but WebKit currently uses
> "0".

Microsoft documents suggest using the 'x' width and we're trying to match
Windows. Other than that I don't have any good reason...

Expand Messages | Collapse Messages