Issue 1265001: Pass the proper number of fields to update remembered set for.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1265001: Pass the proper number of fields to update remembered set for. (Closed)

Created:
10 years, 9 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Pass the proper number of fields to update remembered set for. By oversight kPointerSize more fields were passed. BUG=39128 Committed: http://code.google.com/p/v8/source/detail?r=4242

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Mads Ager (chromium)

10 years, 9 months ago (2010-03-24 09:24:15 UTC) #2

LGTM, seems to do what the old code did now.

Adding a regression test as both you and Kasper suggested would be great.