Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1265001: Pass the proper number of fields to update remembered set for. (Closed)

Created:
10 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Pass the proper number of fields to update remembered set for. By oversight kPointerSize more fields were passed. BUG=39128 Committed: http://code.google.com/p/v8/source/detail?r=4242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Guys, may you have a look?
10 years, 9 months ago (2010-03-24 09:08:00 UTC) #1
Mads Ager (chromium)
10 years, 9 months ago (2010-03-24 09:24:15 UTC) #2
LGTM, seems to do what the old code did now.

Adding a regression test as both you and Kasper suggested would be great.

Powered by Google App Engine
This is Rietveld 408576698