Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 126301: Linux: Don't try to special case webkit blur when we stop showing right click... (Closed)

Created:
11 years, 6 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
tony, Evan Martin
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)
Visibility:
Public.

Description

Linux: Don't try to special case webkit blur when we stop showing right click context menu. After I spent more time investigating, it seems that when the popup menu closes, it always returns focus to the toplevel that previously had it. Thus we don't have to worry about some other toplevel getting focus without us getting another focus-out. BUG=13554 TEST=right click spellcheck correction works in gmail Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
should have done more testing
11 years, 6 months ago (2009-06-17 22:51:11 UTC) #1
Evan Martin
11 years, 6 months ago (2009-06-17 22:59:52 UTC) #2
LGTM, less code always sounds good to me

Powered by Google App Engine
This is Rietveld 408576698