Issue 126293: Inline mod for integer powers of 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126293: Inline mod for integer powers of 2. (Closed)

Created:
11 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Inline mod for integer powers of 2. Committed: http://code.google.com/p/v8/source/detail?r=2215

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
	M	src/ia32/codegen-ia32.cc	View		2 chunks	+31 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 6 months ago (2009-06-18 07:23:49 UTC) #2

LGTM.

http://codereview.chromium.org/126293/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/126293/diff/1/2#newcode1393
Line 1393: GenericBinaryOpStub stub(op_, overwrite_mode_, flags);
You could write this:

GenericBinaryFlags flags = (op_ == Token::MOD)
  ? SMI_CODE_IN_STUB
  : SMI_CODE_INLINED;

Expand Messages | Collapse Messages