Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/test/chrome_process_util.cc

Issue 126279: Consistently use int64 for integers holding number of milliseconds. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/url_fetcher_protect.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chrome_process_util.cc
diff --git a/chrome/test/chrome_process_util.cc b/chrome/test/chrome_process_util.cc
index 9d858e43bd125389febe18f987f5015373a9f55e..8ad623901985ebc2d5bac02436d8ca5fbe2a03d5 100644
--- a/chrome/test/chrome_process_util.cc
+++ b/chrome/test/chrome_process_util.cc
@@ -42,8 +42,7 @@ void TerminateAllChromeProcesses(const FilePath& data_dir) {
for (it = handles.begin();
it != handles.end() && Time::Now() - start < kExitTimeout;
++it) {
- // TODO(phajdan.jr): Fix int/int64 problems with TimeDelta::InMilliseconds.
- int wait_time_ms = static_cast<int>((Time::Now() - start).InMilliseconds());
+ int64 wait_time_ms = (Time::Now() - start).InMilliseconds();
base::WaitForSingleProcess(*it, wait_time_ms);
}
« no previous file with comments | « chrome/browser/net/url_fetcher_protect.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698