Issue 126279: Consistently use int64 for integers holding number of milliseconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126279: Consistently use int64 for integers holding number of milliseconds. (Closed)

Created:
11 years, 6 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Consistently use int64 for integers holding number of milliseconds. This applies only to things which use TimeDelta::InMilliseconds, because it returns int64. Before this patch callers static_casted that to int, and after this patch they use the returned value as int64. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18626

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -31 lines)			Patch
M	base/message_loop.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/message_loop.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/process_util.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/process_util_posix.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	base/process_util_win.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/history/expire_history_backend.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_fetcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_fetcher_protect.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_fetcher_protect.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/chrome_process_util.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

The goal of this patch is to reduce unnecessary usage of static_cast, and consistency (if ...

11 years, 6 months ago (2009-06-17 16:23:53 UTC) #1

darin (slow to review)

11 years, 6 months ago (2009-06-17 16:38:50 UTC) #2

LGTM

Ideally many of these would change to be TimeDelta parameters, but that doesn't
have to happen now.

Expand Messages | Collapse Messages