Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 126271: Fix unload debugger (Closed)

Created:
11 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix unload debugger. Add a missing handle scope when clearing the debug message handler. BUG=none TEST=cctest/test-debug/DebuggerUnload Committed: http://code.google.com/p/v8/source/detail?r=2206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -33 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +59 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 6 months ago (2009-06-17 13:05:04 UTC) #1
pfeldman
LGTM
11 years, 6 months ago (2009-06-17 13:13:13 UTC) #2
Mads Ager (chromium)
11 years, 6 months ago (2009-06-17 13:28:03 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698