Issue 126267: Add -fno-threadsafe-statics to the Linux build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126267: Add -fno-threadsafe-statics to the Linux build. (Closed)

Created:
11 years, 6 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add -fno-threadsafe-statics to the Linux build. We already depend on our static initializers being thread safe, since MSVC does not implement locking around static initialization. This avoids extra locking (__cxa_guard_acquire / __cxa_guard_release).

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 6 months ago (2009-06-17 16:37:45 UTC) #3

LGTM.

There are a few cases where we use local statics in Mac-specific code.  None of
them should be in multithreadable code, but you never know.  I wouldn't turn
this on on the Mac until we had a chance to look at those uses.

Expand Messages | Collapse Messages