Issue 126227: Fetch the SVN revision number correctly regardless of line endings...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126227: Fetch the SVN revision number correctly regardless of line endings... (Closed)

Created:
11 years, 6 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fetch the SVN revision number correctly regardless of line endings returned by any version of Python on any platform. BUG=14187 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18533

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	build/util/lastchange.py	View		2 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 6 months ago (2009-06-16 21:21:28 UTC) #3

http://codereview.chromium.org/126227/diff/1002/1003
File build/util/lastchange.py (right):

http://codereview.chromium.org/126227/diff/1002/1003#newcode28
Line 28: except OSError, e:
You don't need the ,e here.

Expand Messages | Collapse Messages