Issue 126222: Lands http://codereview.chromium.org/126036 for Thiago....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126222: Lands http://codereview.chromium.org/126036 for Thiago.... (Closed)

Created:
11 years, 6 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Lands http://codereview.chromium.org/126036 for Thiago. From Thiago: This patch is to solve the problem in import/export bookmarks. They aren't exported correctly and also not imported correctly. Now when the bookmarks are exported the character " are escaped to " and when they are imported, they are unescaped. BUG=7505 TEST=Try importing/exporting bookmarks, make sure nothing is broken. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19654

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -11 lines)			Patch
M	AUTHORS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View	1 2	5 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/browser/importer/firefox2_importer.cc	View	1 2	2 chunks	+19 lines, -4 lines	0 comments	Download
M	chrome/browser/importer/firefox_importer_unittest.cc	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download