Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 126200: Don't panic if tickprocessor can't find a shared library.... (Closed)

Created:
11 years, 6 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Don't panic if tickprocessor can't find a shared library. Don't swallow exceptions so we can't see where they are really thrown. Committed: http://code.google.com/p/v8/source/detail?r=2192

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M tools/tickprocessor.js View 2 chunks +17 lines, -16 lines 4 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
11 years, 6 months ago (2009-06-16 13:26:48 UTC) #1
mnaganov (inactive)
http://codereview.chromium.org/126200/diff/1/2 File tools/tickprocessor.js (left): http://codereview.chromium.org/126200/diff/1/2#oldcode171 Line 171: throw e; Hmm... Does rethrowing an exception fails ...
11 years, 6 months ago (2009-06-16 13:32:00 UTC) #2
Erik Corry
http://codereview.chromium.org/126200/diff/1/2 File tools/tickprocessor.js (left): http://codereview.chromium.org/126200/diff/1/2#oldcode171 Line 171: throw e; On 2009/06/16 13:32:00, Michail Naganov wrote: ...
11 years, 6 months ago (2009-06-16 13:44:56 UTC) #3
mnaganov (inactive)
11 years, 6 months ago (2009-06-16 13:51:23 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698