Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: net/url_request/url_request_file_dir_job.cc

Issue 12620: Append a trailing slash on file directory URLs. Thus a link to /directory wil... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_file_dir_job.h ('k') | net/url_request/url_request_file_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_file_dir_job.h" 5 #include "net/url_request/url_request_file_dir_job.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/time.h" 10 #include "base/time.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 SetStatus(URLRequestStatus()); 192 SetStatus(URLRequestStatus());
193 NotifyReadComplete(bytes_read); 193 NotifyReadComplete(bytes_read);
194 } else { 194 } else {
195 NOTREACHED(); 195 NOTREACHED();
196 // TODO: Better error code. 196 // TODO: Better error code.
197 NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, 0)); 197 NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, 0));
198 } 198 }
199 } 199 }
200 } 200 }
201 201
202 bool URLRequestFileDirJob::IsRedirectResponse(
203 GURL* location, int* http_status_code) {
204 // If the URL did not have a trailing slash, treat the response as a redirect
205 // to the URL with a trailing slash appended.
206 std::string path = request_->url().path();
207 if (path[path.size() - 1] != '/') {
tony 2008/11/25 21:42:52 Does path always return at least '/' or do you nee
208 // This happens when we discovered the file is a directory, so needs a
209 // slash at the end of the path.
210 std::string new_path = path;
211 new_path.push_back('/');
212 GURL::Replacements replacements;
213 replacements.SetPathStr(new_path);
214
215 *location = request_->url().ReplaceComponents(replacements);
216 *http_status_code = 301; // simulate a permanent redirect
217 return true;
218 }
219
220 return false;
221 }
222
OLDNEW
« no previous file with comments | « net/url_request/url_request_file_dir_job.h ('k') | net/url_request/url_request_file_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698