Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 126195: Fix issue 380. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 380. Don't infer name for a function if a result of its call is assigned to a variable / property. E.g., in this case: a = function() { ... } (); the function must remain anonymous because 'a' doesn't receive a function reference, but instead a result of its call. BUG=http://code.google.com/p/v8/issues/detail?id=380 TEST=cctest/test-func-name-inference/Issue380 Committed: http://code.google.com/p/v8/source/detail?r=2185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/rewriter.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-16 10:10:24 UTC) #1
Mads Ager (chromium)
11 years, 6 months ago (2009-06-16 10:42:24 UTC) #2
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698