Issue 126192: Avoid going into runtime system for round-towards-zero operations on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126192: Avoid going into runtime system for round-towards-zero operations on ARM. (Closed)

Created:
11 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
William Hesse, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Avoid going into runtime system for round-towards-zero operations on ARM. Committed: http://code.google.com/p/v8/source/detail?r=2182

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -19 lines)			Patch
M	src/arm/codegen-arm.cc	View	4 chunks	+41 lines, -10 lines	1 comment	Download
M	test/mjsunit/date-parse.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/toint32.js	View	1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-16 09:33:16 UTC) #2

LGTM.

http://codereview.chromium.org/126192/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/126192/diff/1/2#newcode4719
Line 4719: // label if the double isn't in the range -0x80000000 to 0x80000000
(excluding
the label slow

Expand Messages | Collapse Messages