Issue 126189: Implemented fast case for NumberToString where the result is a single charact...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126189: Implemented fast case for NumberToString where the result is a single charact... (Closed)

Created:
11 years, 6 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, kasperl

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implemented fast case for NumberToString where the result is a single character string. Committed: http://code.google.com/p/v8/source/detail?r=2175

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+13 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 6 months ago (2009-06-16 06:41:18 UTC) #2

LGTM!

http://codereview.chromium.org/126189/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/126189/diff/1/2#newcode2419
Line 2419: // Fast case where the result is a one char string.
char -> character

http://codereview.chromium.org/126189/diff/1/2#newcode2426
Line 2426: static const char chars[] = "0123456789abcdefghijklmnopqrstuvwxyz";
Should be something like kChars or kCharsMap, right?

Expand Messages | Collapse Messages