Issue 126188: Improve DST offset computation performance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126188: Improve DST offset computation performance. (Closed)

Created:
11 years, 6 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
William Hesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improve DST offset computation performance. Committed: http://code.google.com/p/v8/source/detail?r=2176

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -9 lines)			Patch
	M	src/date-delay.js	View		3 chunks	+68 lines, -9 lines	1 comment	Download
	M	src/macros.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-16 07:11:29 UTC) #3

http://codereview.chromium.org/126188/diff/1/3
File src/date-delay.js (right):

http://codereview.chromium.org/126188/diff/1/3#newcode153
Line 153: function DaylightSavingsOffset(t) {
Comment the function to state that the algorithm is valid as long as the
daylight savings offset does not change from value A to B, then back to A,
within any one month period.

Won't this cause a problem with laptops and mobile devices?  Do we have any way
of getting notified when the system time settings change?  Otherwise,
long-running javascript may go nuts.  I think it is quite possible for a web
page to stay open while the user adjusts the time zone.

Expand Messages | Collapse Messages