Issue 126185: Improved tab overview animations with better animation and wiring to...

Issue 126185: Improved tab overview animations with better animation and wiring to... (Closed)

Created:
11 years, 6 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Improved tab overview animations with better animation and wiring to message loop. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18523

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+375 lines, -57 lines)			Patch
M	chrome/browser/browser_init.cc	View	1	2 chunks	+9 lines, -0 lines	2 comments	Download
M	chrome/browser/gtk/browser_window_gtk.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/views/tabs/grid.h	View	1	2 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/views/tabs/grid.cc	View	1	4 chunks	+20 lines, -19 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_overview_container.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_overview_container.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_overview_controller.h	View	1	5 chunks	+38 lines, -9 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_overview_controller.cc	View	1	11 chunks	+92 lines, -18 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_overview_drag_controller.cc	View	1	3 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab_overview_grid.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_overview_grid.cc	View	1	3 chunks	+24 lines, -0 lines	0 comments	Download
A	chrome/browser/views/tabs/tab_overview_message_listener.h	View		1 chunk	+52 lines, -0 lines	0 comments	Download
A	chrome/browser/views/tabs/tab_overview_message_listener.cc	View		1 chunk	+76 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	3 chunks	+12 lines, -0 lines	0 comments	Download
M	views/screen_gtk.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/126185/diff/25/1038 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/126185/diff/25/1038#newcode346 Line 346: TabOverviewMessageListener::instance(); Ew. Why?

11 years, 6 months ago (2009-06-16 11:44:47 UTC) #2

sky

11 years, 6 months ago (2009-06-16 14:25:26 UTC) #3

http://codereview.chromium.org/126185/diff/25/1038
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/126185/diff/25/1038#newcode346
Line 346: TabOverviewMessageListener::instance();
On 2009/06/16 11:44:47, Ben Goodger wrote:
> Ew. Why?

Why force creation? TabOverviewMessageListener installs itself as
MessageLoop::Observer. The messages it listens for can come in at any point
during the life time of the app.

Expand Messages | Collapse Messages