Make the generated stubs weak. Enable the unittests that had conflicting symbols.

Make the generated stubs weak.  Enable the unittests that had conflicting symbols.

Also move some of the old mocks into their own namespace.  They were causing linker confusion due to inlining or something which generated bad test executables that segfaulted.

[awong, 2009-06-15 22:59:43]

On 2009/06/15 22:55:20, awong wrote:
> 

running through try servers now. ajwong: weak_ffmpeg-c0216

[scherkus (not reviewing), 2009-06-15 23:03:17]

http://codereview.chromium.org/126170/diff/1/2
File media/base/mock_media_filters.h (right):

http://codereview.chromium.org/126170/diff/1/2#newcode23
Line 23: namespace old_mocks {
add a todo here or at the top of the file saying these are deprecated

http://codereview.chromium.org/126170/diff/1/3
File media/base/pipeline_impl_unittest.cc (right):

http://codereview.chromium.org/126170/diff/1/3#newcode99
Line 99: config_.data_source_behavior =
media::old_mocks::MOCK_DATA_SOURCE_URL_ERROR_IN_INIT;
80 chars

http://codereview.chromium.org/126170/diff/1/5
File media/filters/ffmpeg_demuxer_unittest.cc (right):

http://codereview.chromium.org/126170/diff/1/5#newcode403
Line 403: EXPECT_EQ(2U, demuxer_->GetNumberOfStreams());
should it be lowercase or uppercase U?

http://codereview.chromium.org/126170/diff/1/7
File media/filters/ffmpeg_video_decoder_unittest.cc (right):

http://codereview.chromium.org/126170/diff/1/7#newcode172
Line 172: TEST_F(FFmpegVideoDecoderTest, Do1) {
commented out code?

http://codereview.chromium.org/126170/diff/1/9
File media/filters/test_video_decoder.h (right):

http://codereview.chromium.org/126170/diff/1/9#newcode16
Line 16: #include "media/base/mock_media_filters.h"
order of includes

http://codereview.chromium.org/126170/diff/1/12
File media/media.gyp (right):

http://codereview.chromium.org/126170/diff/1/12#newcode179
Line 179: 'filters/ffmpeg_video_decoder_unittest.cc',
what about mac?

[awong, 2009-06-15 23:27:54]

doh!  Need to proofread my changes before sending!

This should be better.

http://codereview.chromium.org/126170/diff/1/2
File media/base/mock_media_filters.h (right):

http://codereview.chromium.org/126170/diff/1/2#newcode23
Line 23: namespace old_mocks {
On 2009/06/15 23:03:17, scherkus wrote:
> add a todo here or at the top of the file saying these are deprecated

Done.

http://codereview.chromium.org/126170/diff/1/3
File media/base/pipeline_impl_unittest.cc (right):

http://codereview.chromium.org/126170/diff/1/3#newcode99
Line 99: config_.data_source_behavior =
media::old_mocks::MOCK_DATA_SOURCE_URL_ERROR_IN_INIT;
On 2009/06/15 23:03:17, scherkus wrote:
> 80 chars

Done.

http://codereview.chromium.org/126170/diff/1/5
File media/filters/ffmpeg_demuxer_unittest.cc (right):

http://codereview.chromium.org/126170/diff/1/5#newcode403
Line 403: EXPECT_EQ(2U, demuxer_->GetNumberOfStreams());
On 2009/06/15 23:03:17, scherkus wrote:
> should it be lowercase or uppercase U?

Both work.  Switched to lowercase per discussion.

http://codereview.chromium.org/126170/diff/1/9
File media/filters/test_video_decoder.h (right):

http://codereview.chromium.org/126170/diff/1/9#newcode16
Line 16: #include "media/base/mock_media_filters.h"
On 2009/06/15 23:03:17, scherkus wrote:
> order of includes

Done.

[scherkus (not reviewing), 2009-06-15 23:38:18]

LGTM -- one nit that was actually my fault

http://codereview.chromium.org/126170/diff/30/1011
File media/filters/ffmpeg_video_decoder_unittest.cc (right):

http://codereview.chromium.org/126170/diff/30/1011#newcode175
Line 175: .WillOnce(ReturnNull());
indent by 2 -- my bad :)