Issue 126168: Take 2. Make TCPClientSocketPool own the ConnectingSockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126168: Take 2. Make TCPClientSocketPool own the ConnectingSockets. (Closed)

Created:
11 years, 6 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Take 2. Make TCPClientSocketPool own the ConnectingSockets. Fix connecting_sockets_map_ to get updated before running callback. BUG=none TEST=TCPClientSocketPoolTest.RequestTwice BUG=http://crbug.com/13952 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18453

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -59 lines)			Patch
M	net/base/tcp_client_socket_pool.h	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	net/base/tcp_client_socket_pool.cc	View	8 chunks	+22 lines, -41 lines	0 comments	Download
M	net/base/tcp_client_socket_pool_unittest.cc	View	1 chunk	+43 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_unittest.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	5 chunks	+5 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

The change between this and last time is moving the pool_->RemoveConnectingSocket(handle_) call ahead of request.callback->Run(result).

11 years, 6 months ago (2009-06-15 22:48:48 UTC) #1

lgtm

Expand Messages | Collapse Messages