Issue 126163: Bookmark dragging cleanup....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126163: Bookmark dragging cleanup.... (Closed)

Created:
11 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bookmark dragging cleanup. bookmark bar: - re-show on buttons when done dragging - match g_object_ref in drag-begin with g_object_unref in drag-end bookmark manager: - get rid of default tree view drag handling (we override it all anyway, and it was causing problems) - fix index out of bounds crash - when you drag onto a folder, add it at the end of the folder rather than the beginning. TEST=single bookmark dragging should be fully functional, non crashing BUG=14019 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18463

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -26 lines)			Patch
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	5 chunks	+28 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages