Issue 126160: Moving MockFFmpeg to its own file and some media.gyp cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126160: Moving MockFFmpeg to its own file and some media.gyp cleanup. (Closed)

Created:
11 years, 6 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong, Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Moving MockFFmpeg to its own file and some media.gyp cleanup. Step one of having a completely mocked FFmpeg library.

Patch Set 2 : Not ready for mac and linux yet #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -75 lines)			Patch
A	media/base/mock_ffmpeg.h	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	media/base/mock_ffmpeg.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View		2 chunks	+1 line, -58 lines	0 comments	Download
M	media/media.gyp	View	1	5 chunks	+21 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

LGTM Yay! http://codereview.chromium.org/126160/diff/1/3 File media/base/mock_ffmpeg.h (right): http://codereview.chromium.org/126160/diff/1/3#newcode24 Line 24: // Setter/getter for the global instance ...

11 years, 6 months ago (2009-06-15 21:26:08 UTC) #2

LGTM!

Expand Messages | Collapse Messages

Issue 126160: Moving MockFFmpeg to its own file and some media.gyp cleanup. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Not ready for mac and linux yet #

Messages