Stop leaking CGBitmapContextRefs

skia/ext/bitmap_platform_device_mac.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "skia/ext/bitmap_platform_device_mac.h"
 
 #include <time.h>
 
 #include "base/ref_counted.h"
 #include "skia/ext/skia_utils_mac.h"
@@ skipping 191 matching lines @@
 #ifndef NDEBUG
   if (is_opaque) {
     // To aid in finding bugs, we set the background color to something
     // obviously wrong so it will be noticable when it is not cleared
     bitmap.eraseARGB(255, 0, 255, 128);  // bright bluish green
   }
 #endif
 
   if (!context)
     context = CGContextForData(data, width, height);
+  else
+    CGContextRetain(context);
 
-  // The device object will take ownership of the graphics context.
-  return new BitmapPlatformDevice(
+  BitmapPlatformDevice* rv = new BitmapPlatformDevice(
       new BitmapPlatformDeviceData(context), bitmap);
+
+  // The device object took ownership of the graphics context with its own
+  // CGContextRetain call.
+  CGContextRelease(context);
+
+  return rv;
 }
 
 BitmapPlatformDevice* BitmapPlatformDevice::CreateWithData(uint8_t* data,
                                                            int width,
                                                            int height,
                                                            bool is_opaque) {
   CGContextRef context = NULL;
   if (data)
     context = CGContextForData(data, width, height);
 
-  return Create(context, width, height, is_opaque);
+  BitmapPlatformDevice* rv = Create(context, width, height, is_opaque);
+
+  // The device object took ownership of the graphics context with its own
+  // CGContextRetain call.
+  if (context)
+    CGContextRelease(context);
+
+  return rv;
 }
 
 // The device will own the bitmap, which corresponds to also owning the pixel
 // data. Therefore, we do not transfer ownership to the SkDevice's bitmap.
 BitmapPlatformDevice::BitmapPlatformDevice(
     BitmapPlatformDeviceData* data, const SkBitmap& bitmap)
     : PlatformDevice(bitmap),
       data_(data) {
 }
 
@@ skipping 88 matching lines @@
     for (int i = 0; i < height; i++) {
       size_t offset = (i + bitmap_start_y) * row_words + bitmap_start_x;
       for (int j = 0; j < width; j++) {
         adjustor(data + offset + j);
       }
     }
   }
 }
 
 }  // namespace skia