Issue 126158: --issue=126156

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126158: --issue=126156 (Closed)

Created:
11 years, 6 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Committed: http://code.google.com/p/v8/source/detail?r=2184

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	src/ic.cc	View	1	2 chunks	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/126158/diff/1/2 File src/ic.cc (right): http://codereview.chromium.org/126158/diff/1/2#newcode866 Line 866: static bool LookupForStoreIC(JSObject* object, String* name, LookupResult* ...

11 years, 6 months ago (2009-06-16 06:00:06 UTC) #2

antonm

11 years, 6 months ago (2009-06-16 10:06:14 UTC) #3

Thanks a lot, Mads

http://codereview.chromium.org/126158/diff/1/2
File src/ic.cc (right):

http://codereview.chromium.org/126158/diff/1/2#newcode866
Line 866: static bool LookupForStoreIC(JSObject* object, String* name,
LookupResult* lookup) {
On 2009/06/16 06:00:07, Mads Ager wrote:
> Line too long?

Sorry.  Fixed.

Expand Messages | Collapse Messages

Issue 126158: --issue=126156 (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages