Issue 126143: Converting the RSS subscription page to use a background page, as opposed to ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126143: Converting the RSS subscription page to use a background page, as opposed to ... (Closed)

Created:
11 years, 6 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Converting the RSS subscription page to use a background page, as opposed to a toolstrip (since it has no toolstrip UI). BUG=None TEST=The RSS page action should work as before and should not take up any real estate in the toolstrip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18412

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -141 lines)			Patch
A +	chrome/test/data/extensions/samples/subscribe_page_action/background.html	View		1 chunk	+58 lines, -58 lines	0 comments	Download
M	chrome/test/data/extensions/samples/subscribe_page_action/manifest.json	View	1	1 chunk	+23 lines, -25 lines	0 comments	Download
D	chrome/test/data/extensions/samples/subscribe_page_action/toolstrip.html	View	1	1 chunk	+0 lines, -58 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awesome! lgtm

Expand Messages | Collapse Messages