Issue 126140: Properly use data when creating a bitmap platform canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126140: Properly use data when creating a bitmap platform canvas (Closed)

Created:
11 years, 6 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
brettw, Amanda Walker

CC:
chromium-reviews_googlegroups.com, John Grabowski

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Properly use data when creating a bitmap platform canvas. Gets things painting on the screen again. Regressed in r18363. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18415

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -37 lines)			Patch
M	skia/ext/bitmap_platform_device_mac.h	View		1 chunk	+9 lines, -11 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_mac.cc	View	1	3 chunks	+47 lines, -23 lines	0 comments	Download
M	skia/ext/platform_canvas_mac.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Amanda Walker

LGTM. "CreateWithContext(NULL, ...)" seems like a weird way to create the device/canvas *without* a context, ...

11 years, 6 months ago (2009-06-15 19:04:09 UTC) #2

brettw

11 years, 6 months ago (2009-06-15 19:12:00 UTC) #3

LGTM. I'd say that CreateWithContext should really just be called Create. Feel
free to change or not.