Issue 126116: Optimize constant divisions by powers of 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126116: Optimize constant divisions by powers of 2. (Closed)

Created:
11 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimize constant divisions by powers of 2. Committed: http://code.google.com/p/v8/source/detail?r=2164

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	src/parser.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 6 months ago (2009-06-15 09:52:30 UTC) #2

LGTM.

http://codereview.chromium.org/126116/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/126116/diff/1/2#newcode2661
Line 2661: ((y_int - 1) & y_int) == 0) {
Yeah, we kinda know about this trick. Please use IsPowerOf2 from utils.h :-)
(maybe it even fits on one line then).

Expand Messages | Collapse Messages