Creates a new TabContentsViewGtk for views based FE.

Fix build bustage by removing another dependency on browser/gtk by creating a new TabContentsViewGtk specifically for views. This subclasses WidgetGtk similar to how TabContentsViewWin subclasses WidgetWin.

There was a bug in NativeViewHostGtk - reparenting needs to be done atomically using gtk_widget_reparent since GtkWidgets are refcounted and when removed from a container are released, causing a crash when a TabContents is reparented.

The code now compiles thanks to a stubbed BlockedPopupContainer, however there is one remaining issue - the browser window no longer paints and the app instantly hangs. However this is better than the current state so I figured I'd send the code review.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18588

[sky, 2009-06-16 16:01:45]

http://codereview.chromium.org/126107/diff/38/45
File views/controls/native/native_view_host_gtk.cc (right):

http://codereview.chromium.org/126107/diff/38/45#newcode33
Line 33: if (gtk_widget_get_parent(host_->native_view())) {
NOTE: rather than invoking ReparentChild you could ref and unref as is done in
AddedToWidget.

I suspect the ownership of the widget isn't quite right in this class if the
widget is removed and then parented again. But that can be dealt with later.

http://codereview.chromium.org/126107/diff/38/43
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/126107/diff/38/43#newcode178
Line 178: bounds.width(), bounds.height());
I think you need to persist the bounds some how, otherwise Show won't know what
bounds to show the widget at.

http://codereview.chromium.org/126107/diff/38/44
File views/widget/widget_gtk.h (right):

http://codereview.chromium.org/126107/diff/38/44#newcode205
Line 205: GtkWidget* window_contents_;
Why did you rename this? I went with the name child_widget_parent_ as this is
the parent and any child widgets are to be added to.

[Ben Goodger (Google), 2009-06-16 19:53:46]

http://codereview.chromium.org/126107/diff/38/43
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/126107/diff/38/43#newcode178
Line 178: bounds.width(), bounds.height());
On 2009/06/16 16:01:45, sky wrote:
> I think you need to persist the bounds some how, otherwise Show won't know
what
> bounds to show the widget at.

It seems like the bounds setting will be done when the GtkWidget corresponding
to this WidgetGtk is attached to a NativeViewHost - the NativeViewHosts' bounds
will be applied.