Issue 126103: Wean activex_shim from urlmon.lib:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126103: Wean activex_shim from urlmon.lib:... (Closed)

Created:
11 years, 6 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, bradnelson

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Wean activex_shim from urlmon.lib: Remove urlmon.lib from activex_shim's AdditionalDependencies. Add urlmon.lib to AdditionalDependencies in chrome_dll.vcproj and unittests.vcproj. Add activex_shim as a dependency of default_plugin, so the things that link against default_plugin get urlmon.lib from the activex_shim link_settings. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18366

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -12 lines)			Patch
M	chrome/app/chrome_dll.vcproj	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/unit/unittests.vcproj	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/activex_shim/activex_shim.gyp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/default_plugin/default_plugin.gyp	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 6 months ago (2009-06-14 20:08:53 UTC) #1

TBR=nsylvain

Trying to thread this needle (again) as a preparatory step towards trying to
land chrome.dll.

Expand Messages | Collapse Messages