Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 126101: Adds kind-of-live thumbnail generation for a potential tab switcher. (Closed)

Created:
11 years, 6 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds kind-of-live thumbnail generation for a potential tab switcher. This listens to tab events and tries to keep thumbnails ready to go. See thumbnail_generator.cc for a more detailed design. This adds a painting observer to the RenderWidgetHost to enable this new behavior, as well as a notification to allow the thumbnail generator to hook its observer in. There is also a new notification that a backing store has been disabled, which required making the backing stores know about their owning widget hosts. This component is currently disabled. We just need to uncomment the member in Profile and it will start to work. Original review: http://codereview.chromium.org/118420 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18540

Patch Set 1 #

Patch Set 2 : New patvh #

Patch Set 3 : For Checking hopefully #

Unified diffs Side-by-side diffs Delta from patch set Stats (+872 lines, -138 lines) Patch
M chrome/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/profile.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/backing_store.h View 3 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_mac.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_manager.cc View 4 chunks +42 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_x.cc View 1 chunk +18 lines, -20 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 5 chunks +30 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 9 chunks +31 lines, -4 lines 0 comments Download
A chrome/browser/renderer_host/render_widget_host_painting_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_unittest.cc View 7 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 3 chunks +30 lines, -32 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 2 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/test_render_view_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/test_render_view_host.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.cc View 2 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/tab_contents/thumbnail_generator.h View 1 chunk +75 lines, -0 lines 0 comments Download
A chrome/browser/tab_contents/thumbnail_generator.cc View 1 2 1 chunk +321 lines, -0 lines 0 comments Download
A chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 1 2 1 chunk +179 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/common/property_bag.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/transport_dib.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/transport_dib_linux.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/transport_dib_mac.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/transport_dib_win.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_process.cc View 2 chunks +1 line, -16 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698