Using base::Time::Exploded instead of "tm" (FTP PATCH SET 5)

net/ftp/ftp_directory_parser.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Version: MPL 1.1/GPL 2.0/LGPL 2.1
 // The contents of this file are subject to the Mozilla Public License Version
 // 1.1 (the "License"); you may not use this file except in compliance with
 // the License. You may obtain a copy of the License at
 // http://www.mozilla.org/MPL/
 // Software distributed under the License is distributed on an "AS IS" basis,
@@ skipping 23 matching lines @@
 // the provisions above, a recipient may use your version of this file under
 // the terms of any one of the MPL, the GPL or the LGPL.
 
 // Derived from:
 // mozilla/netwerk/streamconv/converters/ParseFTPList.h revision 1.3
 
 
 #ifndef NET_FTP_FTP_DIRECTORY_PARSER_H_
 #define NET_FTP_FTP_DIRECTORY_PARSER_H_
 
-#include <time.h>
 
-#include "base/basictypes.h"
+#include "base/time.h"
 
 namespace net {
 
 struct ListState {
-  void*         magic;          // to determine if previously initialized
-  int64         now_time;       // needed for year determination.
-  struct tm     now_tm;         // needed for year determination.
-  int           lstyle;         // LISTing style.
-  int           parsed_one;     // returned anything yet?
-  char          carry_buf[84];  // for VMS multiline.
-  unsigned int  carry_buf_len;  // length of name in carry_buf.
-  unsigned int  numlines;       // number of lines seen.
+  void*                magic;          // Determine if previously initialized.
+  bool                 now_tm_valid;   // now_tm contains a valid time
+  base::Time::Exploded now_tm;         // needed for year determination.
+  int                  lstyle;         // LISTing style.
+  int                  parsed_one;     // returned anything yet?
+  char                 carry_buf[84];  // for VMS multiline.
+  unsigned int         carry_buf_len;  // length of name in carry_buf.
+  unsigned int         numlines;       // number of lines seen.
 };
 
 enum LineType {
   FTP_TYPE_DIRECTORY,  // LIST line is a directory entry ('result' is valid).
   FTP_TYPE_FILE,       // LIST line is a file's entry ('result' is valid).
   FTP_TYPE_SYMLINK,    // LIST line is a symlink's entry ('result' is valid).
   FTP_TYPE_JUNK,       // LIST line is junk. (cwd, non-file/dir/link, etc).
   FTP_TYPE_COMMENT     // Its not a LIST line (its a "comment").
 };
 
 struct ListResult {
-  LineType      fe_type;
-  const char*   fe_fname;        // pointer to filename
-  unsigned int  fe_fnlen;        // length of filename
-  const char*   fe_lname;        // pointer to symlink name
-  unsigned int  fe_lnlen;        // length of symlink name
-  char          fe_size[40];     // size of file in bytes (<= (2^128 - 1))
-  int           fe_cinfs;        // file system is definitely case insensitive
-  // TODO(ibrar): We should use "base::Time::Exploded" instead of "tm"
-  struct tm     fe_time;         // last-modified time
+  LineType             fe_type;
+  const char*          fe_fname;        // pointer to filename
+  unsigned int         fe_fnlen;        // length of filename
+  const char*          fe_lname;        // pointer to symlink name
+  unsigned int         fe_lnlen;        // length of symlink name
+  char                 fe_size[40];     // size of file in bytes
+                                        // (<= (2^128 - 1))
+  int                  fe_cinfs;        // file system is definitely
+                                        // case insensitive
+  base::Time::Exploded fe_time;         // last-modified time
 };
 
 // ParseFTPLine() parses line from an FTP LIST command.
 //
 // Written July 2002 by Cyrus Patel <cyp@fb14.uni-mainz.de>
 // with acknowledgements to squid, lynx, wget and ftpmirror.
 //
 // Arguments:
 // 'line': line of FTP data connection output. The line is assumed
 // to end at the first '\0' or '\n' or '\r\n'.
@@ skipping 36 matching lines @@
 // between an error message and an NLST line would require ParseList() to
 // recognize all the possible strerror() messages in the world.
 
 LineType ParseFTPLine(const char *line,
                       struct ListState *state,
                       struct ListResult *result);
 
 }  // namespace net
 
 #endif  // NET_FTP_FTP_DIRECTORY_PARSER_H_